Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: updated node to v20 #495

Closed

Conversation

BilalQamar95
Copy link
Contributor

@BilalQamar95 BilalQamar95 commented Jul 25, 2024

Description

  • Regenerated package-lock.json with node v20 and NPM 10.
  • Updated .nvmrc to v20
  • Updated the lockfile version check workflow

Second step in the Node 20 upgrade process, See the tracking issue for further information.

Copy link

codecov bot commented Jul 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.91%. Comparing base (ebab15f) to head (2c87d45).
Report is 11 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #495      +/-   ##
==========================================
- Coverage   88.97%   88.91%   -0.07%     
==========================================
  Files         248      248              
  Lines        4545     4554       +9     
  Branches      940      945       +5     
==========================================
+ Hits         4044     4049       +5     
- Misses        468      472       +4     
  Partials       33       33              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BilalQamar95 BilalQamar95 marked this pull request as draft July 25, 2024 12:55
@BilalQamar95 BilalQamar95 marked this pull request as ready for review August 9, 2024 12:24
@BilalQamar95 BilalQamar95 marked this pull request as draft August 21, 2024 08:43
@BilalQamar95 BilalQamar95 self-assigned this Aug 26, 2024
@BilalQamar95 BilalQamar95 mentioned this pull request Aug 26, 2024
@KristinAoki
Copy link
Member

Closing this PR because this repo will be merged into frontend-app-course-authoring which already has this upgrade in progress.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants